dockolith POC #1331
dockolith POC #1331
Conversation
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
60a4484
to
4145769
Compare
Codecov ReportBase: 92.07% // Head: 92.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1331 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 214 214
Lines 5149 5149
Branches 1094 1094
=======================================
Hits 4741 4741
Misses 385 385
Partials 23 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
1be8fc7
to
c28ccf2
Compare
scripts/e2e/e2e-dockolith.sh
Outdated
| LOCAL_DIR=$(cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd) | ||
|
|
||
| export CI=true | ||
| export SKIP_SETUP_BUILD=1 |
There was a problem hiding this comment.
Don't the E2E tests require the module to be built?
There was a problem hiding this comment.
A build is ran after dockolith is installed, this is just skipping a redundant build
| create_log_group "Create Test Org" | ||
| # Add widget test host to /etc/hosts | ||
| export TEST_ORG_SUBDOMAIN="authjs-test-1" | ||
| echo "${DOCKER_HOST_CONTAINER_IP} ${TEST_ORG_SUBDOMAIN}.okta1.com" >> /etc/hosts |
There was a problem hiding this comment.
This line does not work locally. It can be wrapped in
if [[ -n ${DOCKOLITH_CI} ]]; then
# do the thing
fi
scripts/monolith/start-dockolith.sh
Outdated
|
|
||
| # Dockolith should be installed before running this script | ||
|
|
||
| if [[ -n "${TEST_SUITE_ID}" ]]; then |
There was a problem hiding this comment.
this condition can be removed, dockolith runs locally now
| # Yarn "add" always modifies package.json https://github.com/yarnpkg/yarn/issues/1743 | ||
| # Make a backup of package.json and restore it after install | ||
| cp package.json package.json.bak | ||
| yarn add -DW --no-lockfile file:./scripts/dockolith |
There was a problem hiding this comment.
I think this is where the build happens. Can add --ignore-scripts option to skip the build step
There was a problem hiding this comment.
Adding --ignore-scripts here prevents dockolith from building
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
64c1a96
to
5bc583a
Compare
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
4ea4c1b
to
680cbe8
Compare
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
68bc487
to
a470df4
Compare
jaredperreault-okta
force-pushed
the
jp-OKTA-528462
branch
from
280fd71
to
964c23f
Compare
No description provided.