Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigdecimal as dependency gem #901

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

Watson1978
Copy link
Collaborator

The bigdecimal gem will be changed bundled gem since Ruby 3.4.0.
https://www.ruby-lang.org/en/news/2023/09/14/ruby-3-3-0-preview2-released/

To use bundled gem, it requires to specify the dependency in Gemfile.

This patch will fix following warning with Ruby 3.3.0-preview2.

/Users/watson/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/oj-3.16.1/lib/oj/mimic.rb:3: warning: bigdecimal will be not part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile. Also contact author of  to add bigdecimal into its gemspec.

@ohler55 ohler55 merged commit adb2c1f into ohler55:develop Sep 19, 2023
35 checks passed
@Watson1978 Watson1978 deleted the bigdecimal branch September 19, 2023 23:05
Watson1978 added a commit to Watson1978/oj that referenced this pull request Feb 28, 2024
This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

The mutex_m gem will be changed bundled gem since Ruby 3.4.0.
To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. ohler55#901
Watson1978 added a commit to Watson1978/oj that referenced this pull request Feb 28, 2024
This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

The mutex_m gem will be changed bundled gem since Ruby 3.4.0.
To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. ohler55#901
Watson1978 added a commit to Watson1978/oj that referenced this pull request Feb 28, 2024
This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

The mutex_m gem will be changed bundled gem since Ruby 3.4.0.
To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. ohler55#901
ohler55 pushed a commit that referenced this pull request Feb 28, 2024
* CI: Add mutex_m gem as dependency in rails 6.1 tests

This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

The mutex_m gem will be changed bundled gem since Ruby 3.4.0.
To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. #901

* CI: Add base64 gem as dependency

* CI: Add drb gem as dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants