Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor converting number to string by using optimized function #886

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Watson1978
Copy link
Collaborator

Refactor converting number to string by using optimized function which introduced at #879

@ohler55
Copy link
Owner

ohler55 commented Jun 10, 2023

Before merging, is the performance the same or better with this change?

@ohler55 ohler55 merged commit 4bfb4b5 into ohler55:develop Jun 16, 2023
36 checks passed
@Watson1978
Copy link
Collaborator Author

Sorry for late reply.

When I run benchmark with same code in #879,
it is 0.8% slower by this PR.

I believe it is a tolerance error.

Before

Warming up --------------------------------------
             Oj.dump   431.211k i/100ms
Calculating -------------------------------------
             Oj.dump      4.323M (± 0.7%) i/s -     21.992M in   5.087412s

After

Warming up --------------------------------------
             Oj.dump   425.450k i/100ms
Calculating -------------------------------------
             Oj.dump      4.288M (± 0.3%) i/s -     21.698M in   5.060483s

@Watson1978 Watson1978 deleted the oj_longlong_to_string branch June 16, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants