Remove checking whether rb_gc_mark_movable exists #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the oj gem supports Ruby 2.7+. rb_gc_mark_movable() has introduced at Ruby 2.7. Ref. https://github.com/ruby/ruby/blob/v2_7_0/include/ruby/intern.h#L540 So, we can use rb_gc_mark_movable() freely in oj gem.
ohler55
approved these changes
Apr 22, 2023
|
39 |
Watson1978
added a commit
that referenced
this pull request
May 7, 2023
This reverts commit 7e991e6.
ohler55
pushed a commit
that referenced
this pull request
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the oj gem supports Ruby 2.7+.
rb_gc_mark_movable() has introduced at Ruby 2.7.
Ref. https://github.com/ruby/ruby/blob/v2_7_0/include/ruby/intern.h#L540
So, we can use rb_gc_mark_movable() freely in oj gem.