Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows Rails CI #861

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Mar 2, 2023

I'm expecting this to fail as I was testing on an earlier branch before.
I figured out one of the failure methods from going through the first error message that pointed to https://github.com/tzinfo/tzinfo/wiki/Resolving-TZInfo::DataSourceNotFound-Errors

Opening to see if the other failure gives anyone else an idea

@nschonni
Copy link
Contributor Author

nschonni commented Mar 2, 2023

You can see in the failure that it's not picking up the correct timezone still

 Failure:
TestJSONEncoding#test_time_to_json_includes_local_offset [D:/a/oj/oj/test/activesupport6/encoding_test.rb:129]:
--- expected
+++ actual
@@ -1 +1 @@
-"\"2005-02-01T15:15:10.000-05:00\""
+"\"2005-02-01T15:15:10.000+00:00\""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant