Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set default mode #669

Merged
merged 2 commits into from Jul 3, 2021
Merged

Don't set default mode #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19e28d9
Don't set default mode
ohler55 Jul 1, 2021
1c73305
Release prep
ohler55 Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,5 +1,9 @@
# CHANGELOG

## 3.11.8 - 2021-07-03

- Fixed or reverted change that set the default mode when optimize_Rails was called.

## 3.11.7 - 2021-06-22

- Fixed exception type when parsing after `Oj::Rails.mimic_JSON` is called.
Expand Down
3 changes: 2 additions & 1 deletion ext/oj/rails.c
View file
Open in desktop
Expand Up @@ -828,7 +828,8 @@ rails_mimic_json(VALUE self) {
json = rb_define_module("JSON");
}
oj_mimic_json_methods(json);
oj_default_options.mode = RailsMode;
// Setting the default mode breaks the prmoise in the docs not to.
//oj_default_options.mode = RailsMode;

return Qnil;
}
Expand Down