Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): use Rat.SetString instead of UnmarshalText #655

Merged
merged 4 commits into from Nov 3, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Nov 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 74.18% // Head: 74.19% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (110347b) compared to base (adf8110).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   74.18%   74.19%           
=======================================
  Files         170      170           
  Lines       11881    11885    +4     
=======================================
+ Hits         8814     8818    +4     
  Misses       2609     2609           
  Partials      458      458           
Impacted Files Coverage Δ
gen/write.go 88.94% <100.00%> (+0.20%) ⬆️
validate/float.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit c874be2 into ogen-go:main Nov 3, 2022
@tdakkota tdakkota deleted the fix/simplify-rats branch November 3, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants