Handle OSErrors when running show path commands #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bash may not always be installed, for example on OpenWrt, and attempting to call the show path commands for Bash will cause a FileNotFoundError to be raised. This wraps the subprocess call with a try statement and returns the empty string in the case of an OSError.
jefferyto
added a commit
to jefferyto/openwrt-packages
that referenced
this pull request
Nov 10, 2023
The patches have been submitted upstream in ofek/userpath#52 and ofek/userpath#53. From the README: This is a tool for modifying a user's PATH. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
1715173329
pushed a commit
to openwrt/packages
that referenced
this pull request
Nov 15, 2023
The patches have been submitted upstream in ofek/userpath#52 and ofek/userpath#53. From the README: This is a tool for modifying a user's PATH. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash may not always be installed, for example on OpenWrt, and attempting to call the show path commands for Bash will cause a
FileNotFoundErrorto be raised.This wraps the subprocess call with a try statement and returns the empty string in the case of an
OSError.