[FW][FIX] tools: prevent pillow 7.0 bug on exif_transpose #65611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 X-original-commit: b83c48d
|
Ping @d-fence
To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On odoo.sh, in some circumstances, when uploading an image as attachment
in odoo leads to a blank image thumbnail. The same image was
successfully uploaded in the same odoo version on runbot instance.
After some investigations, it appears that the issue comes from the
python-pillow version used. A few bugs exists [0,1,2] in python-pillow
7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0
[3,4,5] (packaged in Debian and specified in Odoo requirements.txt),
that causes the
ImageOps.exif_transposemethod to fail.The present issue can be considered as a corner case as only images with
particular exif tags cause the issue.
The present fix is a simple workaround by first checking the presence of
the orientation tag and using it, we can avoid a call to the
exif_transposemethod.opw-2369166
[0] python-pillow/Pillow#4346
[1] python-pillow/Pillow#3973
[2] python-pillow/Pillow#4238
[3] python-pillow/Pillow#4637
[4] python-pillow/Pillow#3980
[5] python-pillow/Pillow#4009
Forward-Port-Of: #65584