Commits on Oct 14, 2020

1. [FIX] core: PyPDF2 suppresses warnings …

   By default, PdfFileReader will monkeypatch the `warnings` module even
   if it has no reason whatsoever to do so and suppress the
   `captureWarnings` behavior.
   
   This means as soon as we've loaded a PDF file, `warnings.warn` don't
   trigger `logging` warnings anymore, and become invisible.
   
   This can lead to non-deterministic behaviors depending as warnings may
   or may not be suppressed depending when they occur relative to loading
   a PDF e.g. load a module which runs a test which loads a PDF before a
   module triggering a warning and the warning won't be visible, other
   way around it will.
   
   Except ofc while we have an override to PdfFileReader it's not
   used *everywhere*, so need to monkeypatch the init.

   

   xmo-odoo committed Oct 14, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for a8292ec
   • Browse repository at this point

   Copy the full SHA

   a8292ec View commit details

   Browse the repository at this point in the history