[FW][FIX] base: duration widget for unsupported babel format #155978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JKE-be @mart-e cherrypicking of pull request #155909 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
JKE-be
force-pushed
the
saas-17.1-17.0-duration-keyerror-jke-uiXs-fw
branch
from
e01fa87
to
5f9ddd8
Compare
|
@robodoo r+ |
C3POdoo
requested review from
a team,
rco-odoo and
ryv-odoo
and removed request for
a team
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 X-original-commit: 7cc2436
JKE-be
force-pushed
the
saas-17.1-17.0-duration-keyerror-jke-uiXs-fw
branch
from
5f9ddd8
to
56b6f08
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 closes #155978 X-original-commit: 7cc2436 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Jérémy Kersten <jke@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 closes #155978 X-original-commit: 7cc2436 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Jérémy Kersten <jke@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale.
Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing.
python-babel/babel#827
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #155909