Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] merge: faster intersection with zone #4202

Closed
wants to merge 1 commit into from
Closed

[perf] merge: faster intersection with zone #4202

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

Steps to reproduce:

  • add 1000 rows
  • copy a simple value
  • select a huge zone (all columns, all rows)
  • paste => watch your browser burn. The process never ends.

Task: : 3924969

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 13, 2024

Pull request status dashboard.

@LucasLefevre
[PERF] merge: faster intersection with zone
fd9c651 
Steps to reproduce:
- add 1000 rows
- copy a simple value
- select a huge zone (all columns, all rows)
- paste
=> watch your browser burn. The process never ends.

Task: 3924969
pro-odoo
pro-odoo approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request May 16, 2024
@LucasLefevre
[PERF] merge: faster intersection with zone
4903083 
Steps to reproduce:
- add 1000 rows
- copy a simple value
- select a huge zone (all columns, all rows)
- paste
=> watch your browser burn. The process never ends.

closes #4202

Task: 3924969
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this May 16, 2024
This was referenced May 16, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucasLefevre @robodoo @pro-odoo