[FIX] Composer: F4 handler should not bubble out of the composer #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488
pro-odoo
reviewed
May 15, 2024
| this.env.model.dispatch("CYCLE_EDITION_REFERENCES"); | ||
| this.processContent(); | ||
| ev.stopPropagation(); |
There was a problem hiding this comment.
Whenever it's possible, I prefer to have functions like stopPropagation, preventDefault, ... in the beginning of the function. But it's a personal preference, feel free to ignore
robodoo
pushed a commit
that referenced
this pull request
May 15, 2024
Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4201 Task: 3916488 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pull request 21261, the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands.
Task: 3916488
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Footnotes
https://github.com/odoo/o-spreadsheet/issues/2126 ↩