Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] *: use less string.split #4187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VincentSchippefilt
Copy link
Collaborator

@VincentSchippefilt VincentSchippefilt commented May 8, 2024

In most cases, when we want to split a string in exactly 1 or 2 parts, using indexOf(delimiter) is faster than split.

updated code like

const index = xc.lastIndexOf("!")
if (index !== -1) {
  xc = xc.slice(index + 1)
}

is 2x faster than the original:

if (ref.includes("!")) {
  ref = ref.split("!").at(-1)
}

image

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 8, 2024

In most cases, when we want to split a string in exactly 1 or 2 parts,
using indexOf(delimiter) is faster than split.

updated code like
```
const index = xc.lastIndexOf("!")
if (index !== -1) {
  xc = xc.slice(index + 1)
}
```

is 2x faster than the original:
```
if (ref.includes("!")) {
  ref = ref.split("!").at(-1)
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants