Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] chartjs: remove forced hover dot size #4169

Closed

Conversation

hokolomopo
Copy link
Contributor

Description

Because of a wrong configuration of ChartJs, we had to force the size of hovered chart points to be the same as the default size.

Since the chartJs config was fixed in 14ef3a6, it's no longer needed.

Task: : 3869065

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Because of a wrong configuration of ChartJs, we had to force the
size of hovered chart points to be the same as the default size.

Since the chartJs config was fixed in 14ef3a6, it's no longer needed.

Task: 3869065
@robodoo
Copy link
Collaborator

robodoo commented May 6, 2024

@rrahir
Copy link
Collaborator

rrahir commented May 24, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request May 24, 2024
Because of a wrong configuration of ChartJs, we had to force the
size of hovered chart points to be the same as the default size.

Since the chartJs config was fixed in 14ef3a6, it's no longer needed.

closes #4169

Task: 3869065
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants