[IMP] pivot: select dimension with arrow keys #4135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasLefevre
force-pushed
the
master-use-autocomplete-lul
branch
3 times, most recently
from
006e4aa
to
4d02f6c
Compare
LucasLefevre
changed the title
LucasLefevre
force-pushed
the
master-use-autocomplete-lul
branch
from
4d02f6c
to
727021c
Compare
rrahir
requested changes
May 13, 2024
src/components/composer/autocomplete_dropdown/autocomplete_dropdown_store.ts
Outdated
Show resolved
Hide resolved
LucasLefevre
force-pushed
the
master-use-autocomplete-lul
branch
from
727021c
to
8d48688
Compare
rrahir
requested changes
May 14, 2024
| break; | ||
| case "ArrowUp": | ||
| case "ArrowDown": | ||
| this.autoComplete.moveSelection(ev.key); |
There was a problem hiding this comment.
Suggested change
| this.autoComplete.moveSelection(ev.key); | |
| this.autoComplete.moveSelection(ev.key === "ArrowDown" ? "next" : "previous"); |
There was a problem hiding this comment.
Oups, fixed 😅
The test is on odoo's side until pivots lands in o-spreadsheet
https://github.com/odoo/enterprise/pull/61671/files#diff-4b8b6f5d4dffedcb22e750296d4e58fb62e198e42789e82d1f1d6a28d4bdbc9dR511
In the side panel of pivot properties, when clicking on Add to add a new dimension, the user can now use the arrow keys and Enter key to select a dimension. Note: tests are in odoo because there's currently no pivot in o-spreadsheet alone. Task: 3893736
LucasLefevre
force-pushed
the
master-use-autocomplete-lul
branch
from
8d48688
to
1006edb
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 14, 2024
In the side panel of pivot properties, when clicking on Add to add a new dimension, the user can now use the arrow keys and Enter key to select a dimension. Note: tests are in odoo because there's currently no pivot in o-spreadsheet alone. closes #4135 Task: 3893736 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist