Master recompute zones everywhere laa #4134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laa-odoo
force-pushed
the
master-recompute-zones-everywhere-laa
branch
2 times, most recently
from
ae2dc9c
to
a73c7de
Compare
rrahir
requested changes
May 14, 2024
There was a problem hiding this comment.
A little rebase is in order :/
I think we could add the use of recompute zone in a couple more places as well but there might be a reason you didn't. I'm thinking of
- DataValidationPlugin -> handle "DELETE_CONTENT"
- AutomaticSumPlugin -> handle "SUM_SELECTION"
- MergePlugin -> handle "ADD_MERGE","REMOVE_MERGE"
What do you think of those?
Ok with For the others, the behavior can functionally change. So no |
For performance reasons, this commit proposes to add recomputeZonnes wherever we cross all the elements of a list of zones. Task: 3893550
Task: 3893550
laa-odoo
force-pushed
the
master-recompute-zones-everywhere-laa
branch
from
a73c7de
to
d930502
Compare
|
@robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
|
Off we go then :D |
robodoo
pushed a commit
that referenced
this pull request
May 17, 2024
For performance reasons, this commit proposes to add recomputeZonnes wherever we cross all the elements of a list of zones. Task: 3893550 Part-of: #4134
robodoo
pushed a commit
that referenced
this pull request
May 17, 2024
closes #4134 Task: 3893550 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[REF] recompute zones: use recomputeZones on missing places
For performance reasons, this commit proposes to add
recomputeZonnes wherever we cross all the elements of
a list of zones.
[REF] zones helper: remove unused helpers
Task: 3893550
review checklist