Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for string split #2

Closed
wants to merge 9 commits into from
Closed

Add specs for string split #2

wants to merge 9 commits into from

Conversation

dvdherron
Copy link

@dvdherron dvdherron commented Nov 2, 2022

See sass/sass#1950
Closes: sass#1832

See the latest version of the proposal here

[skip dart-sass]

@dvdherron
Copy link
Author

@mirisuzanne @stacyk
Mainly looking for feedback on whether or not it seems like I'm missing any tests. Took a guess at file naming. If you have thoughts on how that could possibly be improved before I send this to Sass that would be great too. Thanks!

@dvdherron dvdherron marked this pull request as ready for review November 15, 2022 13:49
================================================================================
<===> private_use_character/input.scss
// Dart Sass emits private-use characters as escapes in expanded mode, but it
// should stil treat them as single characters for the purpose of functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: still

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll fix.

Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dvdherron dvdherron closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants