New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(update-webhooks): remove classes from elements #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
the
Type: Maintenance
Any dependency, housekeeping, and clean up Issue or PR
label
Jun 16, 2022
ghost
added this to Maintenance
in JS
Jun 16, 2022
I'd like to wait on #641 before merging this, in order to create the least friction/conflicts between PRs |
G-Rath
reviewed
Jun 16, 2022
G-Rath
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
oscard0m
approved these changes
Jun 24, 2022
oscard0m
requested changes
Jun 25, 2022
wolfy1339
force-pushed
the
remove-classes
branch
3 times, most recently
from
June 26, 2022 17:50
67a8d77
to
71528ff
Compare
oscard0m
approved these changes
Jun 26, 2022
gr2m
reviewed
Jun 26, 2022
This change will remove all the classes from the cached HTML, except for classes which we actually look for in our code in order to extract payload examples Fixes #642
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
wolfy1339
force-pushed
the
remove-classes
branch
from
June 28, 2022 17:10
510feac
to
d3194d1
Compare
🎉 This PR is included in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will remove all the classes from the cached HTML, except for classes which we actually look for in our code in order to extract payload examples
Fixes #642