Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(update-webhooks): remove classes from elements #646

Merged
merged 6 commits into from Jun 28, 2022

Conversation

wolfy1339
Copy link
Member

This change will remove all the classes from the cached HTML, except for classes which we actually look for in our code in order to extract payload examples

Fixes #642

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 16, 2022
@ghost ghost added this to Maintenance in JS Jun 16, 2022
@wolfy1339
Copy link
Member Author

I'd like to wait on #641 before merging this, in order to create the least friction/conflicts between PRs

lib/get-html.ts Outdated Show resolved Hide resolved
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

lib/get-html.ts Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 force-pushed the remove-classes branch 3 times, most recently from 67a8d77 to 71528ff Compare June 26, 2022 17:50
@wolfy1339 wolfy1339 requested a review from oscard0m June 26, 2022 17:50
lib/get-html.ts Show resolved Hide resolved
@wolfy1339 wolfy1339 marked this pull request as ready for review June 28, 2022 17:10
wolfy1339 and others added 4 commits June 28, 2022 13:10
This change will remove all the classes from the cached HTML, except for classes which we actually look for in our code in order to extract payload examples

Fixes #642
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
@wolfy1339 wolfy1339 merged commit 7560770 into master Jun 28, 2022
JS automation moved this from Maintenance to Done Jun 28, 2022
@wolfy1339 wolfy1339 deleted the remove-classes branch June 28, 2022 17:20
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

Automated update PRs: reduce noise of cache-only updates
5 participants