Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: package is now ESM #469

Merged
merged 5 commits into from Apr 30, 2024
Merged

feat: package is now ESM #469

merged 5 commits into from Apr 30, 2024

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: package is now ESM

@wolfy1339
feat: package is now ESM
49fbf55 
BREAKING CHANGE: package is now ESM
@wolfy1339 wolfy1339 added Type: Feature New feature or request Status: Blocked Some technical or requirement is blocking the issue Type: Breaking change Used to note any change that requires a major version bump labels Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

Tests are failing because of @octokit/rest not being updated yet

@wolfy1339 wolfy1339 marked this pull request as ready for review April 30, 2024 19:30
@wolfy1339
Copy link
Member Author

Tests are failing because of @octokit/rest not being updated yet

I recreated the Octokit constructor from @octokit/rest in the tests, it should be removed whenever octokit/rest.js#413 is finished

gr2m
gr2m approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
image

@wolfy1339 wolfy1339 merged commit a058734 into main Apr 30, 2024
6 checks passed
@wolfy1339 wolfy1339 deleted the beta branch April 30, 2024 20:47
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released Status: Blocked Some technical or requirement is blocking the issue Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wolfy1339 @gr2m