Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Adds test with draft as an argument on creating pull requests #1671

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

hfvmarques
Copy link
Contributor

@hfvmarques hfvmarques commented Feb 29, 2024

Resolves #ISSUE_NUMBER


Before the change?

There were no doc nor test highlighting the possibility of creating a Pull Request as a draft using the client, and I thought that's important. I had to look around a little to find it out.

After the change?

Now it's highlighted and the "feature" can be used freely.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@hfvmarques hfvmarques changed the title test: adds test with draft argument on create pull request Adds test with draft as an argument on creating pull requests Feb 29, 2024
@hfvmarques hfvmarques marked this pull request as ready for review February 29, 2024 01:18
@nickfloyd nickfloyd changed the title Adds test with draft as an argument on creating pull requests maint: Adds test with draft as an argument on creating pull requests Feb 29, 2024
@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 29, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hfvmarques thanks for the contributions here! ❤️

@nickfloyd nickfloyd merged commit c680963 into octokit:main Feb 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants