maint: Drop runtime dependency on base64 #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
nickfloyd
added
the
Type: Maintenance
nickfloyd
approved these changes
Feb 13, 2024
nickfloyd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1658 added base64 as a dependency in order to supress a warning/error on Ruby 3.3/3.4.
There are two places here where it is used, and these can instead be replaced by the
packmethod which the base64 gem just wraps around.I've instead added it as a development dependency so that tests can continue to make use of it.
Other gems have taken a similar approach:
base64gem from runtime dependency rubocop/rubocop#12313base64gem dependency socketry/protocol-http#51Before the change?
base64is part of the depenency tree.After the change?
base64is removed.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!