Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of caching + authorization middlewares #1661

Open
wants to merge 6 commits into
base: v8
Choose a base branch
from
Open

Fix order of caching + authorization middlewares #1661

wants to merge 6 commits into from

Commits on Jan 18, 2024

  1. Place Faraday::HttpCache middleware after the Faraday::Request::Autho… 

    …rization middleware because it needs the Authorization header to be set
    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2d56e82 View commit details
    Browse the repository at this point in the history

  2. Add tests for caching

    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bbbe982 View commit details
    Browse the repository at this point in the history

  3. Use a shared store for the Faraday::HttpCache middleware

    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7504f3c View commit details
    Browse the repository at this point in the history

  4. Make sure the default test_github_token differs from the default test… 

    …_github_token_two
    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c1abe4f View commit details
    Browse the repository at this point in the history

  5. Make sure to freeze time at the point that the cassette was recorded … 

    …so that the cache is considered fresh
    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3b30724 View commit details
    Browse the repository at this point in the history

  6. More calls

    @DimitriosLisenko
    DimitriosLisenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    28a38b1 View commit details
    Browse the repository at this point in the history