Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make faraday retry fully optional. #1569

Closed
wants to merge 2 commits into from
Closed

Make faraday retry fully optional. #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be99ce
Remove warning message if faraday-retry is not installed and faraday …
expeehaa May 1, 2023
08a910a
Add README note about "faraday-retry".
expeehaa May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ Access the library in Ruby:

require 'octokit'

Octokit.rb uses the `faraday` gem under the hood. When using `faraday > 2`,
automatic request retries may be enabled by also installing the gem `faraday-retry`.

## Making requests

[API methods][] are available as client instance methods.
Expand Down
2 changes: 1 addition & 1 deletion lib/octokit/default.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
begin
require 'faraday/retry'
rescue LoadError
Octokit::Warnable.octokit_warn 'To use retry middleware with Faraday v2.0+, install `faraday-retry` gem'
# Ignore that faraday-retry is not present.
end
end

Expand Down