Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Environments API #1554

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Added Environments API #1554

merged 3 commits into from
Apr 3, 2023

Conversation

jer-k
Copy link
Contributor

@jer-k jer-k commented Mar 21, 2023

Resolves #1552


Behavior

Before the change?

After the change?

  • Environments API is implemented

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@jer-k
Copy link
Contributor Author

jer-k commented Mar 21, 2023

Is there a preference for the VCR files formatting? I was looking at the deployments API tests and those files were a single line of JSON, where as mine are formatted over many lines

@kfcampbell
Copy link
Member

I'm not aware of a preference for cassette formatting. I think it's okay to leave as-is.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 1ec0b48 into octokit:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Environments API
2 participants