Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 1.9.2 in Octokit::Client::Contents#create_contents #1442

Merged
merged 2 commits into from Jun 8, 2022
Merged

Drop support for Ruby 1.9.2 in Octokit::Client::Contents#create_contents #1442

merged 2 commits into from Jun 8, 2022

Commits on Jun 8, 2022

  1. Drop support for Ruby 1.9.2 in `Octokit::Client::Contents#create_cont… 

    …ents`

The `#create_contents` method currently has code, added for
compatability ruby Ruby 1.9.2, which uses different `Base64`
methods depending on the Ruby version.

This removes that code, since we don't support 1.9.2 and
the `.strict_encode64` method has been present since 1.9.3.

Fixes #1433.
    @timrogers
    timrogers committed Jun 8, 2022
    Copy the full SHA
    4867c0f View commit details
    Browse the repository at this point in the history

  2. Merge branch '4-stable' into base64

    @nickfloyd
    nickfloyd committed Jun 8, 2022
    Copy the full SHA
    be67ec0 View commit details
    Browse the repository at this point in the history