Enable Rubocop - the sequel #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timrogers
force-pushed
the
enable-rubocop-redux
branch
from
fc315ee
to
50bbe05
Compare
timrogers
force-pushed
the
enable-rubocop-redux
branch
from
50bbe05
to
0fa2e75
Compare
|
Theoretically, Rubocop autocorrection shouldn't lead to any substantive changes in the meaning of your code, but it can make mistakes from time to time. I have a high level of confidence though that we're safe: the tests pass, and I have manually read through the changes to check for anything evident (although this is obviously challenging given the length of the diff). |
timrogers
force-pushed
the
enable-rubocop-redux
branch
2 times, most recently
from
a735bc7
to
b304823
Compare
timrogers
force-pushed
the
enable-rubocop-redux
branch
from
b304823
to
0097549
Compare
ERB in Ruby 2.3 doesn't seem to be frozen string literal compatible - at least under certain cases. I observed a number of test failures in GitHub Actions when working with templates, generating an error like this: ``` (erb):1:in `concat': can't modify frozen String (RuntimeError) ``` You can see an example [here][1]. It seems prudent just to ignore this since (a) people are unlikely to use Ruby 2.3, (b) we are set to drop support for it and (c) it's even more unlikely that people use Ruby 2.3 *and* frozen string literals. [1]: https://github.com/octokit/octokit.rb/runs/6792298625?check_suite_focus=true
timrogers
force-pushed
the
enable-rubocop-redux
branch
from
0097549
to
fa00889
Compare
This was referenced Jun 8, 2022
nickfloyd
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #1432, again trying to enable Rubocop in CI and autocorrect what we can, whilst keeping the gem actually working 😅 ❤️
I decided to start again with a fresh PR because the original PR had a very ugly history - lots of embarrassing fiddling around getting the right
TargetRubyVersionfor Rubocop! - and I didn't want to destroy it as there were some useful comments in there.It's worth noting that, to support linting compatible with Ruby 2.3 (which is the current version we actually support, despite what the gemspec claims!), we have to downgrade Rubocop to an earlier version.