Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Rubocop in CI and automatically correct the offences we can correct #1432

Closed
wants to merge 18 commits into from
Closed

Enable Rubocop in CI and automatically correct the offences we can correct #1432

wants to merge 18 commits into from

Commits on Jun 7, 2022

  1. Fix Rubocop configuration so Rubocop can run

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    2938113 View commit details
    Browse the repository at this point in the history

  2. Target Rubocop to Ruby 2.0, our earliest supported version

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    9c4efd5 View commit details
    Browse the repository at this point in the history

  3. Autocorrect Rubocop offences for already enabled cops

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    64e7009 View commit details
    Browse the repository at this point in the history

  4. Revert problematic Configurable#each_key Rubocop autocorrects

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3e5a177 View commit details
    Browse the repository at this point in the history

  5. Enable new Rubocop cops that have not been turned on yet

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b24c5c2 View commit details
    Browse the repository at this point in the history

  6. Autocorrect Rubocop offences for new cops

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    8a68ea7 View commit details
    Browse the repository at this point in the history

  7. Generate todo list of outstanding Rubocop offences

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    76e53b8 View commit details
    Browse the repository at this point in the history

  8. Fix strange indentation in RateLimit

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    ec1c3e9 View commit details
    Browse the repository at this point in the history

  9. Don't require MFA to push releases to RubyGems 

    This change was added by a Rubocop auto-correct. It's a good thing
to have, but we should add it consciously in its own PR.
    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    905ce0e View commit details
    Browse the repository at this point in the history

  10. Add missing parentheses to method calls in Repositories

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    824d691 View commit details
    Browse the repository at this point in the history

  11. Use Array#to_h in Octokit::Default

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d526770 View commit details
    Browse the repository at this point in the history

  12. Run Rubocop in GitHub Actions on push and PR

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    f389342 View commit details
    Browse the repository at this point in the history

  13. Disable cop which expects us to require MFA for RubyGems pushes

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    dedc568 View commit details
    Browse the repository at this point in the history

  14. Remove safe navigation operator usage which doesn't work with Ruby 2.0

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    06015a6 View commit details
    Browse the repository at this point in the history

  15. Disable Style/SafeNavigation cop until we are on a supported Ruby ver… 

    …sion
    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    f4e286c View commit details
    Browse the repository at this point in the history

  16. Autocorrect Rubocop offences

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    a97818d View commit details
    Browse the repository at this point in the history

  17. Revert code style changes to Preview#warn_preview

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    56951ca View commit details
    Browse the repository at this point in the history

  18. Refresh Rubocop todo list

    @timrogers
    timrogers committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c3672f3 View commit details
    Browse the repository at this point in the history