Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Octokit working with Ruby's immutable ("frozen") string literals functionality #1426

Merged
merged 4 commits into from Jun 6, 2022
Merged

Get Octokit working with Ruby's immutable ("frozen") string literals functionality #1426

merged 4 commits into from Jun 6, 2022

Commits on Jun 1, 2022

  1. CI: Use RUBYOPT: "--enable-frozen-string-literal" 

    If it works, then great, if not, we learned something.
    @olleolleolle @timrogers
    olleolleolle authored and timrogers committed Jun 1, 2022
    Copy the full SHA
    766812c View commit details
    Browse the repository at this point in the history

  2. CI: Install a newer RubyGems on Ruby 2.5 

    For details: rubygems/rubygems#4837 (comment)
    @olleolleolle @timrogers
    olleolleolle authored and timrogers committed Jun 1, 2022
    Copy the full SHA
    2959325 View commit details
    Browse the repository at this point in the history

  3. build_error_message: Use mutable string 

    In order to support --enable-frozen-literal, this change explicitly uses a mutable string - the unary plus does that.
    @olleolleolle @timrogers
    olleolleolle authored and timrogers committed Jun 1, 2022
    Copy the full SHA
    5cbfa3d View commit details
    Browse the repository at this point in the history

  4. errors.rb: Mutable strings

    @olleolleolle @timrogers
    olleolleolle authored and timrogers committed Jun 1, 2022
    Copy the full SHA
    d713396 View commit details
    Browse the repository at this point in the history