Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses of FaradayMiddleware#on_complete should not be private #1316

Merged
merged 2 commits into from Dec 28, 2020
Merged

Uses of FaradayMiddleware#on_complete should not be private #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fde2a2
`on_complete` shouldn't be private
tarebyte Dec 28, 2020
3756964
Remove private from FeedParser as well
tarebyte Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/octokit/response/feed_parser.rb
View file
Open in desktop
Expand Up @@ -7,8 +7,6 @@ module Response
# Parses RSS and Atom feed responses.
class FeedParser < Faraday::Response::Middleware

private

def on_complete(env)
if env[:response_headers]["content-type"] =~ /(\batom|\brss)/
require 'rss'
Expand Down
2 changes: 0 additions & 2 deletions lib/octokit/response/raise_error.rb
View file
Open in desktop
Expand Up @@ -9,8 +9,6 @@ module Response
# HTTP status codes returned by the API
class RaiseError < Faraday::Response::Middleware

private

def on_complete(response)
if error = Octokit::Error.from_response(response)
raise error
Expand Down