Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Microsoft.SourceLink.GitHub package to perform linking #2074

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

shiftkey
Copy link
Member

I want to do away with the use of DotNetCliToolReference inside here (there's a kludge that I'll explain when we get to it) and for now it looks like Microsoft.SourceLink.* are the current ways to achieve this (with some options that I might look into later).

For now, I just want to confirm this works and passes sourcelink test for each build.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2074 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2074   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         538      538           
  Lines       14138    14138           
=======================================
  Hits         9481     9481           
  Misses       4657     4657

@shiftkey shiftkey merged commit 03aa908 into master Jan 28, 2020
@shiftkey shiftkey deleted the switch-to-new-sourcelink branch January 28, 2020 13:07
@shiftkey
Copy link
Member Author

shiftkey commented Feb 3, 2020

release_notes: Switch over to Microsoft.SourceLink.GitHub for embeddeding GitHub URLs into assemblies

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants