Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added pnpm into README.md installs #2416

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

JajarGaming
Copy link
Contributor

Behavior

Before the change?

  • pnpm wasn't in the README.md install documentation

After the change?

  • pnpm is in the README.md install documentation

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • [x ] No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@ghost ghost added this to Inbox in JS Apr 2, 2023
@JajarGaming
Copy link
Contributor Author

for some odd reason I'm unable to add Labels

@wolfy1339 wolfy1339 added the Type: Documentation Improvements or additions to documentation label Apr 2, 2023
@ghost ghost moved this from Inbox to Documentation in JS Apr 2, 2023
@JajarGaming JajarGaming changed the title feat: Added pnpm into README.md installs docs: Added pnpm into README.md installs Apr 2, 2023
@wolfy1339
Copy link
Member

for some odd reason I'm unable to add Labels

That is the normal behaviour on GitHub. Only people added to an organization, or as a repository contributor can add labels.

The section in the PR template that asks for a label, you only need to keep the label that applies to the PR

@JajarGaming
Copy link
Contributor Author

Ah, ok!

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JajarGaming Thanks for the contrib here. ❤️

@nickfloyd nickfloyd merged commit 371d5e5 into octokit:main Apr 5, 2023
8 checks passed
JS automation moved this from Documentation to Done Apr 5, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.0.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Documentation Improvements or additions to documentation
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants