Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace usage of node-fetch with Fetch API #2149

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 31, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
node-fetch ^2.6.7 -> ^3.0.0 age adoption passing confidence

Release Notes

node-fetch/node-fetch (node-fetch)

v3.3.1

Compare Source

Bug Fixes

v3.3.0

Compare Source

Features

v3.2.10

Compare Source

Bug Fixes

v3.2.9

Compare Source

Bug Fixes
  • Headers: don't forward secure headers on protocol change (#​1599) (e87b093)

v3.2.8

Compare Source

Bug Fixes

v3.2.7

Compare Source

Bug Fixes

v3.2.6

Compare Source

Bug Fixes

v3.2.5

Compare Source

Bug Fixes

v3.2.4

Compare Source

Bug Fixes

v3.2.3

Compare Source

Bug Fixes

v3.2.2

Compare Source

Bug Fixes

v3.2.1

Compare Source

Bug Fixes

v3.2.0

Compare Source

Features

v3.1.1

Compare Source

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.0.0...v3.1.0

v3.0.0

Compare Source

version 3 is going out of a long beta period and switches to stable

One major change is that it's now a ESM only package
See changelog for more information about all the changes.

v2.6.12

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Aug 31, 2021
@ghost ghost added this to Inbox in JS Aug 31, 2021
@ghost ghost moved this from Inbox to Maintenance in JS Aug 31, 2021
gr2m
gr2m previously requested changes Aug 31, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not ready for node-fetch v3, as it's a native ES Module. We will be once the work is done in https://github.com/octokit/octokit-next.js

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from c1ab5f9 to 5aeddd4 Compare September 3, 2021 16:13
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from 4acdce8 to 32cb750 Compare September 16, 2021 09:48
@wolfy1339 wolfy1339 added the Status: Blocked Some technical or requirement is blocking the issue label Jun 23, 2022
@ghost ghost moved this from Maintenance to Blocked in JS Jun 23, 2022
@nickfloyd
Copy link
Contributor

We are not ready for node-fetch v3, as it's a native ES Module. We will be once the work is done in https://github.com/octokit/octokit-next.js

@gr2m do you feel like this is something we should ignore for now given that the "next" work is still a little way into the future?

@gr2m
Copy link
Contributor

gr2m commented Jun 27, 2022

With ignore you mean to explicitly ignore node-fetch in the renovate config, or just ignore this pull request?

I would just leave as is, leave this pull request open, so folks can find and subscribe to it to be notified when anything changes

@octokit octokit deleted a comment Sep 27, 2022
@octokit octokit deleted a comment Sep 27, 2022
@ghost ghost moved this from Blocked to Maintenance in JS Nov 28, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from 73e3f59 to c173984 Compare December 5, 2022 03:36
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 5 times, most recently from 8c53da9 to 72d0ba7 Compare December 12, 2022 19:43
@renovate renovate bot changed the title chore(deps): update dependency node-fetch to v3 Update dependency node-fetch to v3 Dec 17, 2022
@renovate renovate bot changed the title Update dependency node-fetch to v3 chore(deps): update dependency node-fetch to v3 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from e8882df to a1bb067 Compare January 3, 2023 16:20
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from d08f08c to fd36fc8 Compare June 20, 2023 23:48
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from 1143e03 to 2f08ab6 Compare July 11, 2023 17:11
@wolfy1339
Copy link
Member

This should be removed instead

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from 3848aa1 to a89ec33 Compare July 20, 2023 15:25
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 4 times, most recently from 6443eee to e13d667 Compare July 28, 2023 08:20
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from f80b3ec to 20ef117 Compare August 8, 2023 16:48
@wolfy1339 wolfy1339 self-assigned this Aug 8, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 20ef117 to bf210e7 Compare August 9, 2023 17:23
@renovate
Copy link
Contributor Author

renovate bot commented Aug 10, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@wolfy1339 wolfy1339 changed the title chore(deps): update dependency node-fetch to v3 test: replace usage of node-fetch with Fetch API Aug 10, 2023
@wolfy1339 wolfy1339 dismissed gr2m’s stale review August 10, 2023 21:46

node-fetch is getting removed

@wolfy1339 wolfy1339 merged commit 0be4af0 into main Aug 10, 2023
7 checks passed
@wolfy1339 wolfy1339 deleted the renovate/node-fetch-3.x branch August 10, 2023 21:47
@github-actions
Copy link

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm-blocked Temporary label to denote esm dependency blocker released Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

3 participants