Skip to content

Commit

Permalink
Merge pull request #13 from octodns/isort
Browse files Browse the repository at this point in the history
Use pyproject.toml for tooling, add isort management of imports
  • Loading branch information
ross committed Feb 4, 2023
2 parents a115bb9 + 458bc7b commit 106cf5c
Show file tree
Hide file tree
Showing 9 changed files with 54 additions and 37 deletions.
2 changes: 2 additions & 0 deletions .git-blame-ignore-revs
@@ -1,2 +1,4 @@
# Commit that added in black formatting support
371fcdc5ef75eb1613ae3df40f4ef431a00d4698
# Commit for isort formatting changes
730af9a05e5cc89e60b28eb1e912275613ab5618
4 changes: 2 additions & 2 deletions octodns_etchosts/__init__.py
Expand Up @@ -2,11 +2,11 @@
#
#

import re
from collections import defaultdict
from logging import getLogger
from os import makedirs, path
from os.path import isdir
from logging import getLogger
import re

from octodns.provider.base import BaseProvider

Expand Down
14 changes: 14 additions & 0 deletions pyproject.toml
@@ -0,0 +1,14 @@
[tool.black]
line-length=80
skip-string-normalization=true
skip-magic-trailing-comma=true

[tool.isort]
profile = "black"
known_first_party="octodns_etchosts"
known_octodns="octodns"
line_length=80
sections="FUTURE,STDLIB,THIRDPARTY,OCTODNS,FIRSTPARTY,LOCALFOLDER"

[tool.pytest.ini_options]
pythonpath = "."
57 changes: 29 additions & 28 deletions requirements-dev.txt
@@ -1,43 +1,44 @@
# DO NOT EDIT THIS FILE DIRECTLY - use ./script/update-requirements to update
Pygments==2.13.0
attrs==22.1.0
black==22.10.0
bleach==5.0.1
build==0.8.0
Pygments==2.14.0
attrs==22.2.0
black==23.1.0
bleach==6.0.0
build==0.10.0
certifi==2022.12.7
cffi==1.15.1
charset-normalizer==2.1.1
charset-normalizer==3.0.1
click==8.1.3
cmarkgfm==0.8.0
commonmark==0.9.1
coverage==6.5.0
cmarkgfm==2022.10.27
coverage==7.1.0
docutils==0.19
exceptiongroup==1.0.0rc9
importlib-metadata==5.0.0
iniconfig==1.1.1
exceptiongroup==1.1.0
importlib-metadata==6.0.0
iniconfig==2.0.0
isort==5.11.5
jaraco.classes==3.2.3
keyring==23.9.3
keyring==23.13.1
markdown-it-py==2.1.0
mdurl==0.1.2
more-itertools==9.0.0
mypy-extensions==0.4.3
packaging==21.3
pathspec==0.10.1
pep517==0.13.0
pkginfo==1.8.3
platformdirs==2.5.2
mypy-extensions==1.0.0
packaging==23.0
pathspec==0.11.0
pkginfo==1.9.6
platformdirs==2.6.2
pluggy==1.0.0
pycparser==2.21
pyflakes==2.5.0
pyparsing==3.0.9
pyflakes==3.0.1
pyproject_hooks==1.0.0
pytest-cov==4.0.0
pytest-network==0.0.1
pytest==7.2.0
readme-renderer==37.2
pytest==7.2.1
readme-renderer==37.3
requests-toolbelt==0.10.1
requests==2.28.1
requests==2.28.2
rfc3986==2.0.0
rich==12.6.0
rich==13.3.1
tomli==2.0.1
twine==4.0.1
urllib3==1.26.12
twine==4.0.2
urllib3==1.26.14
webencodings==0.5.1
zipp==3.10.0
zipp==3.12.0
2 changes: 1 addition & 1 deletion requirements.txt
@@ -1,6 +1,6 @@
# DO NOT EDIT THIS FILE DIRECTLY - use ./script/update-requirements to update
PyYAML==6.0
dnspython==2.2.1
dnspython==2.3.0
fqdn==1.5.1
idna==3.4
natsort==8.2.0
Expand Down
2 changes: 0 additions & 2 deletions script/coverage
Expand Up @@ -22,8 +22,6 @@ grep -r -I --line-number "# pragma: +no.*cover" $SOURCE_DIR && {
exit 1
}

export PYTHONPATH=.:$PYTHONPATH

pytest \
--disable-network \
--cov-reset \
Expand Down
3 changes: 2 additions & 1 deletion script/format
Expand Up @@ -6,4 +6,5 @@ SOURCES=$(find *.py octodns_* tests -name "*.py")

. env/bin/activate

black --line-length=80 --skip-string-normalization --skip-magic-trailing-comma "$@" $SOURCES
isort "$@" $SOURCES
black "$@" $SOURCES
2 changes: 0 additions & 2 deletions script/test
Expand Up @@ -14,6 +14,4 @@ if [ ! -f "$ACTIVATE" ]; then
fi
. "$ACTIVATE"

export PYTHONPATH=.:$PYTHONPATH

pytest --disable-network "$@"
5 changes: 4 additions & 1 deletion setup.py
@@ -1,7 +1,8 @@
from os import environ
from setuptools import find_packages, setup
from subprocess import CalledProcessError, check_output

from setuptools import find_packages, setup


def descriptions():
with open('README.md') as fh:
Expand Down Expand Up @@ -43,6 +44,8 @@ def version():
+ (
'black>=22.3.0',
'build>=0.7.0',
# >=5.12.0 does not support python 3.7, we still do
'isort==5.11.5',
'pyflakes>=2.2.0',
'readme_renderer[md]>=26.0',
'twine>=3.4.2',
Expand Down

0 comments on commit 106cf5c

Please sign in to comment.