Merge pull request #8 from octodns/isort

Use pyproject.toml for tooling, add isort management of imports

.git-blame-ignore-revs

@@ -0,0 +1,2 @@
+# Commit for isort formatting changes
+74da40543b4fcee8edf373552d044125fce7ad74

octodns_bind/__init__.py

@@ -2,18 +2,18 @@
 #
 #
 
-from dns import tsigkeyring
-from dns.exception import DNSException
-from dns.update import Update as DnsUpdate
-import dns.name
-import dns.query
-import dns.zone
-import dns.rdatatype
-
 from logging import getLogger
 from os import listdir
 from os.path import join
 
+import dns.name
+import dns.query
+import dns.rdatatype
+import dns.zone
+from dns import tsigkeyring
+from dns.exception import DNSException
+from dns.update import Update as DnsUpdate
+
 from octodns.provider.base import BaseProvider
 from octodns.record import Create, Record, Rr, Update
 from octodns.source.base import BaseSource
@@ -120,7 +120,7 @@ def zone_records(self, zone):
                 return []
 
             records = []
-            for (name, ttl, rdata) in z.iterate_rdatas():
+            for name, ttl, rdata in z.iterate_rdatas():
                 rdtype = dns.rdatatype.to_text(rdata.rdtype)
                 if rdtype in self.SUPPORTS:
                     records.append(
@@ -178,7 +178,7 @@ def zone_records(self, zone):
 
         records = []
 
-        for (name, ttl, rdata) in z.iterate_rdatas():
+        for name, ttl, rdata in z.iterate_rdatas():
             rdtype = dns.rdatatype.to_text(rdata.rdtype)
             if rdtype in self.SUPPORTS:
                 records.append(Rr(name.to_text(), rdtype, ttl, rdata.to_text()))

pyproject.toml

@@ -0,0 +1,14 @@
+[tool.black]
+line-length=80
+skip-string-normalization=true
+skip-magic-trailing-comma=true
+
+[tool.isort]
+profile = "black"
+known_first_party="octodns_bind"
+known_octodns="octodns"
+line_length=80
+sections="FUTURE,STDLIB,THIRDPARTY,OCTODNS,FIRSTPARTY,LOCALFOLDER"
+
+[tool.pytest.ini_options]
+pythonpath = "."

requirements-dev.txt

@@ -1,43 +1,44 @@
 # DO NOT EDIT THIS FILE DIRECTLY - use ./script/update-requirements to update
-Pygments==2.13.0
-attrs==22.1.0
-black==22.10.0
-bleach==5.0.1
-build==0.8.0
+Pygments==2.14.0
+attrs==22.2.0
+black==23.1.0
+bleach==6.0.0
+build==0.10.0
 certifi==2022.12.7
 cffi==1.15.1
-charset-normalizer==2.1.1
+charset-normalizer==3.0.1
 click==8.1.3
-cmarkgfm==0.8.0
-commonmark==0.9.1
-coverage==6.5.0
+cmarkgfm==2022.10.27
+coverage==7.1.0
 docutils==0.19
-exceptiongroup==1.0.0rc9
-importlib-metadata==5.0.0
-iniconfig==1.1.1
+exceptiongroup==1.1.0
+importlib-metadata==6.0.0
+iniconfig==2.0.0
+isort==5.11.5
 jaraco.classes==3.2.3
-keyring==23.9.3
+keyring==23.13.1
+markdown-it-py==2.1.0
+mdurl==0.1.2
 more-itertools==9.0.0
-mypy-extensions==0.4.3
-packaging==21.3
-pathspec==0.10.1
-pep517==0.13.0
-pkginfo==1.8.3
-platformdirs==2.5.2
+mypy-extensions==1.0.0
+packaging==23.0
+pathspec==0.11.0
+pkginfo==1.9.6
+platformdirs==2.6.2
 pluggy==1.0.0
 pycparser==2.21
-pyflakes==2.5.0
-pyparsing==3.0.9
+pyflakes==3.0.1
+pyproject_hooks==1.0.0
 pytest-cov==4.0.0
 pytest-network==0.0.1
-pytest==7.2.0
-readme-renderer==37.2
+pytest==7.2.1
+readme-renderer==37.3
 requests-toolbelt==0.10.1
-requests==2.28.1
+requests==2.28.2
 rfc3986==2.0.0
-rich==12.6.0
+rich==13.3.1
 tomli==2.0.1
-twine==4.0.1
-urllib3==1.26.12
+twine==4.0.2
+urllib3==1.26.14
 webencodings==0.5.1
-zipp==3.10.0
+zipp==3.12.0

requirements.txt

@@ -1,6 +1,6 @@
 # DO NOT EDIT THIS FILE DIRECTLY - use ./script/update-requirements to update
 PyYAML==6.0
-dnspython==2.2.1
+dnspython==2.3.0
 fqdn==1.5.1
 idna==3.4
 natsort==8.2.0

script/coverage

@@ -25,8 +25,6 @@ grep -r -I --line-number "# pragma: +no.*cover" $SOURCE_DIR && {
 export BIND_KEY_NAME=
 export BIND_KEY_SECRET=
 
-export PYTHONPATH=.:$PYTHONPATH
-
 pytest \
   --disable-network \
   --cov-reset \

script/format

@@ -6,4 +6,5 @@ SOURCES=$(find *.py octodns_* tests -name "*.py")
 
 . env/bin/activate
 
-black --line-length=80 --skip-string-normalization --skip-magic-trailing-comma "$@" $SOURCES
+isort "$@" $SOURCES
+black "$@" $SOURCES

script/test

@@ -17,6 +17,4 @@ fi
 export BIND_KEY_NAME=
 export BIND_KEY_SECRET=
 
-export PYTHONPATH=.:$PYTHONPATH
-
 pytest --disable-network "$@"

setup.py

@@ -1,7 +1,8 @@
 from os import environ
-from setuptools import find_packages, setup
 from subprocess import CalledProcessError, check_output
 
+from setuptools import find_packages, setup
+
 
 def descriptions():
     with open('README.md') as fh:
@@ -43,6 +44,8 @@ def version():
         + (
             'black>=22.3.0',
             'build>=0.7.0',
+            # >=5.12.0 does not support python 3.7, we still do
+            'isort==5.11.5',
             'pyflakes>=2.2.0',
             'readme_renderer[md]>=26.0',
             'twine>=3.4.2',

tests/test_provider_octodns_bind.py

@@ -2,16 +2,16 @@
 #
 #
 
-import dns.zone
-from dns.exception import DNSException
-
 from os.path import exists
 from shutil import copyfile
 from unittest import TestCase
 from unittest.mock import patch
 
-from octodns.zone import Zone
+import dns.zone
+from dns.exception import DNSException
+
 from octodns.record import Record, Rr, ValidationError
+from octodns.zone import Zone
 
 from octodns_bind import (
     AxfrSource,