Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery #3526

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Remove jquery #3526

wants to merge 9 commits into from

Conversation

andrew
Copy link
Member

@andrew andrew commented Dec 12, 2023 •
edited

Using https://youmightnotneedjquery.com to see if I can use built in browser methods to remove the dependency on jquery.

Files:

  • octobox.js
  • comments.js
  • notifications.js
  • application.js
  • search_suggestion.js
    • removing search history items currently broken
  • replace jquery_ujs with rails_ujs

Notes:

  • bootstrap 4 js still needs jquery

@andrew andrew added enhancement Improvements and features dependencies Updates to ruby gems dependencies 📝 work in progress It's not quite done yet! JavaScript labels Dec 12, 2023
@andrew andrew marked this pull request as draft December 12, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Updates to ruby gems dependencies enhancement Improvements and features JavaScript 📝 work in progress It's not quite done yet!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andrew