Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QueryBuilder upsert() method. #531

Merged
merged 3 commits into from Oct 20, 2020

Conversation

LukeTowers
Copy link
Contributor

Pulls in the work by @paras-malhotra in laravel/framework#34698 & laravel/framework#34712 for use in October CMS.

@LukeTowers
Copy link
Contributor Author

@bennothommo if you could adapt the unit tests from those two PRs for this library, that would be fantastic :)

Copy link
Contributor

@bennothommo bennothommo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Everything looks good to me.

@bennothommo
Copy link
Contributor

@LukeTowers I shall port the unit tests shortly :)

@bennothommo
Copy link
Contributor

@LukeTowers unit tests added.

@LukeTowers LukeTowers merged commit 05d3e90 into develop Oct 20, 2020
@LukeTowers LukeTowers deleted the wip/add-upsert-support branch October 20, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants