Use rustix instead of libc in the Unix backend #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustix is a crate that provides an interface to system functions on Unix-like operating systems. It is a wrapper around Linux syscalls on Linux and libc on other operating systems. In addition to being safer, since it uses direct syscalls it reduces instruction counts on Linux. This commit replaces usages of libc with rustix. In addition to removing all unsafe code from the unix backend, it should also speed it up a little on Linux. Note that this bumps the MSRV of this crate to v1.63. This makes the "io-safety" feature useless, so I've made it an empty feature. Signed-off-by: John Nunley <dev@notgull.net>
|
@oconnor663 Any chance you can take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustix is a crate that provides an interface to system functions on
Unix-like operating systems. It is a wrapper around Linux syscalls on
Linux and libc on other operating systems. In addition to being safer,
since it uses direct syscalls it reduces instruction counts on Linux.
This commit replaces usages of libc with rustix. In addition to removing
all unsafe code from the unix backend, it should also speed it up a
little on Linux. Note that this bumps the MSRV of this crate to v1.63.
This makes the "io-safety" feature useless, so I've made it an empty
feature.