Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no error when using --force #820

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented May 13, 2024

  • Fix ENOENT error when using --force flag by ensuring the destination directory is deleted
  • Remove lodash.throttle
  • Replace http-call with got

[skip-validate-pr]

@mdonnalley mdonnalley added the enhancement New feature or request label May 13, 2024
Copy link

git2gus bot commented May 13, 2024

This issue has been linked to a new work item: W-15750437

@WillieRuemmele
Copy link
Contributor

QA Notes


✅ :

 ➜  sf update --force
@salesforce/cli: Updating CLI from 2.40.7-bde121f to 2.40.7-bde121f... !
    Error: ENOENT: no such file or directory, rename '/Users/william.ruemmele/.local/share/sf/client/2.40.7-bde121f.partial.54065/sf' -> '/Users/william.ruemmele/.local/share/sf/client/2.40.7-bde121f'
    Code: ENOENT
➜  dreamhouse-lwc git:(main) ✗  hub:(DevHub) scratch:(test-s1osczj7iyfc@example.com)
 ➜  sf update --force
 ›   Warning: @oclif/plugin-update is a linked ESM module and cannot be auto-transpiled. Existing compiled source will be used instead.
 ›   Warning: @oclif/plugin-update is a linked ESM module and cannot be auto-transpiled. Existing compiled source will be used instead.
# Release notes for 'sf':

## 2.40.7 (May 8, 2024) [stable]

.
.
.

@salesforce/cli: Updating CLI from 2.40.7-bde121f to 2.40.7-bde121f... done

@WillieRuemmele WillieRuemmele merged commit 8415299 into main May 14, 2024
13 checks passed
@WillieRuemmele WillieRuemmele deleted the mdonnalley/no-error-on-force branch May 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants