fix: wrongly packaging child bundles on MacOS #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's an issue with CircleCI pipelines.
|
|
|
@mshanemc @mdonnalley I've fixed merge conflicts. You're free to review now :) |
|
@IGassmann thanks for the PR We recently switched from CircleCI to Github Actions. Looks like the actions aren't running for any PRs that were open when we made the switch. If it's not a problem, could you open a new PR so that we can get the tests running on your changes? Thanks! |
|
@mdonnalley sounds good. Here's the new PR: #971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS's
pkgbuildlook for valid components in sub-directories when using the--rootflag. This cause the build process to mark some files in a project to be processed bypkgbuildand breaks the resulting CLI.On my CLI project https://github.com/IGassmann/web-img-optimizer
pkgbuildwould process Chrome which exists in the npm dependencypuppeteer. Due to that, puppeteer wouldn't work anymore since Chrome was modified bypkgbuild.To avoid that,
pkgbuildneeds to be passed an empty configuration file. It will then not look for valid component in the sub-directories of the project to process them, and will ship the whole directory root as it is.Here's the man page of
pkgbuild.