New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tarballs based commands not considering config from package.json #799
Merged
mdonnalley
merged 6 commits into
oclif:mdonnalley/799
from
rannn505:fix-tarballs-cmd-not-consider-pkgjson
Feb 17, 2022
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
75528d1
fix: remove flags defaults and let Tarballs.buildConfig to determine …
rannn505 146230f
fix: applying fix on promote command
rannn505 55471a3
fix: set xz true by default
rannn505 71c3690
Merge branch 'main' into fix-tarballs-cmd-not-consider-pkgjson
rannn505 e7c866d
Merge branch 'main' into fix-tarballs-cmd-not-consider-pkgjson
rannn505 b337478
Update tarballs.ts
rannn505 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not remove the
default
here since that would be a breaking changeIt might be a better solution to change this line to prefer
updateConfig.node.targets
overoptions.targets
. However, that's not a great solution either since user's would never be able to override what's the configured targets@peternhale @RodEsp Do you have any opinions on this? It looks like the
default
for thetargets
flag was added soon after theoclif-dev
commands were migrated intooclif
: #458There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdonnalley Why is this a ״breaking change״?
Correct me if i'm wrong but it seems like if
flags?.targets?
isundefined
the following line takesTARGETS
array as a fallback (if not defined on package.json) which is exactly the same behaviour.oclif/src/tarballs/config.ts
Line 70 in 71c3690
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be the correct; command flag then config then default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rannn505 you're right, I hadn't considered that