Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'target' argument when packing/uploading macOS #1033

Merged
merged 1 commit into from Nov 29, 2022
Merged

feat: add 'target' argument when packing/uploading macOS #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/commands/pack/macos.ts
View file
Open in desktop
Expand Up @@ -141,12 +141,15 @@ the CLI should already exist in a directory named after the CLI that is the root
description: 'optionally specify a path to a tarball already generated by NPM',
required: false,
}),
targets: Flags.string({
description: 'comma-separated targets to pack (e.g.: darwin-x64,darwin-arm64)',
}),
}

async run(): Promise<void> {
if (process.platform !== 'darwin') this.error('must be run from macos')
const {flags} = await this.parse(PackMacos)
const buildConfig = await Tarballs.buildConfig(flags.root)
const buildConfig = await Tarballs.buildConfig(flags.root, {targets: flags?.targets?.split(',')})
const {config} = buildConfig
const c = config.pjson.oclif as OclifConfig
if (!c.macos) this.error('package.json is missing an oclif.macos config')
Expand Down
3 changes: 2 additions & 1 deletion src/commands/upload/macos.ts
View file
Open in desktop
Expand Up @@ -13,11 +13,12 @@ export default class UploadMacos extends Command {

static flags = {
root: Flags.string({char: 'r', description: 'path to oclif CLI root', default: '.', required: true}),
targets: Flags.string({char: 't', description: 'comma-separated targets to upload (e.g.: darwin-x64,darwin-arm64)'}),
}

async run(): Promise<void> {
const {flags} = await this.parse(UploadMacos)
const buildConfig = await Tarballs.buildConfig(flags.root)
const buildConfig = await Tarballs.buildConfig(flags.root, {targets: flags?.targets?.split(',')})
const {s3Config, config, dist} = buildConfig
const S3Options = {
Bucket: s3Config.bucket!,
Expand Down