feat: remove qq and parallelize build/pack/promote #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
changed the title
peternhale
previously requested changes
Nov 23, 2022
| @@ -18,7 +17,6 @@ This can be used to create oclif CLIs that use the system node or that come prel | |||
| } | |||
|
|
|||
| async run(): Promise<void> { | |||
| const prevCwd = qq.cwd() | |||
There was a problem hiding this comment.
@mshanemc why is managing cwd no longer necessary?
There was a problem hiding this comment.
all the paths are now either absolute or relative to the project.
Use of process.exec instead of qq sometimes passes in a cwd (still absolute or relative to the project).
There was a problem hiding this comment.
nothing ever changes the cwd, which is what was breaking the previous attempt at parallelization
* test: integration tests in parallel * test: restore debian integration tests
RodEsp
suggested changes
Nov 29, 2022
RodEsp
suggested changes
Nov 29, 2022
Co-authored-by: Rodrigo Espinosa de los Monteros <1084688+RodEsp@users.noreply.github.com>
just manually. I checked it again with the new changes via. ../oclif-repos/oclif-oclif/bin/dev promote --channel qqqa --version 7.179.0 --sha 4383be1I'm looking into the integration test options |
RodEsp
previously approved these changes
Nov 30, 2022
RodEsp
dismissed
peternhale’s stale review
Comments were addressed. Re-review please.
RodEsp
suggested changes
Nov 30, 2022
RodEsp
previously approved these changes
Nov 30, 2022
RodEsp
previously approved these changes
Nov 30, 2022
RodEsp
approved these changes
Dec 5, 2022
mattwebbio
pushed a commit
to appfolio/oclif
that referenced
this pull request
Dec 29, 2022
* feat: remove qq and parallelize build/promote * chore: reformat pjson * refactor: remove redundant objects * refactor: pr feedback * feat: publishes debian packages with qq * test: integration tests in parallel * test: restore debian integration tests * chore: remove ds_store * chore: ignore dsStore * chore: ignore dist * Update src/commands/upload/deb.ts Co-authored-by: Rodrigo Espinosa de los Monteros <1084688+RodEsp@users.noreply.github.com> * fix: cwd on pretarball * refactor: pr feedback * test: integration test for tarball promote * test: revert unnecessary trims * perf: optional xz hashes in parallel * chore: fix pjson format * refactor: remove unused conditional * fix: osslsign command requires "sign" Co-authored-by: Rodrigo Espinosa de los Monteros <1084688+RodEsp@users.noreply.github.com>
lukepolo
reviewed
Jan 6, 2023
| // this workaround puts the code in both places that the redirect was doing | ||
| // with this, the docs are correct. The copies are all done in parallel so it shouldn't be too costly. | ||
| const uploadWorkaround = (file: string) => { | ||
| const cloudKey = `${cloudKeyBase}/apt/./${file}` |
There was a problem hiding this comment.
Removing the ./ fixes the issue here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had to drop the --parallel flag on builds because of a bug.
remove
qqjsand itsqq.cdthat's causing the problem with parallelization.make sure each build process has its own directory isolation
parallelize all the things
@W-12107459@
side effects
fix #347
test: restores integration testing for Debian builds (comment said they weren't runnable on CircleCI. Works on gha)
test: runs integration tests in parallel on different OSes to test both mac and deb packing
perf metrics [mac, 2.4 GHz 8-Core Intel Core i9]
rm -rf dist test/tmp tmpon gha builds (2 core machine). [mac tests can't run because they only run on macs]