This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
decrease build times for pack command #330
Open
fivetanley
wants to merge
10
commits into
main
Choose a base branch
from
decrease-pack-times
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 15, 2021
-
feat: decrease build times for pack command
- We can reuse the tarball and append new files (node binaries in this case) instead of compressing/extracting multiple times. This prevents un-necessary copying of files in the built tarball. We can also build all `targets` in parallel in the following way: - Download Node.js versions for targets in parallel instead of serially - Use [workerpool][1] to create gzip files in parallel - Run all `xz` compression with maximum available threads. xz has [supported multicore computation since 5.2 (2014)][1]. - Like gzip, run all `xz` compression in parallel instead of waiting for each target to build. Running this in the Heroku CLI produced identical tarballs in 65% amount of time (~111s seconds vs ~344 seconds before this change). It's likely even a bit faster since I was running it locally which has some boot-up time due to ts-node compiling typescript at runtime. [1]: https://www.npmjs.com/package/workerpool [2]: https://www.phoronix.com/scan.php?page=news_item&px=MTg3MDM
Configuration menu - View commit details
-
Copy full SHA for a1e505f - Browse repository at this point
Copy the full SHA a1e505fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bec78fc - Browse repository at this point
Copy the full SHA bec78fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a85824 - Browse repository at this point
Copy the full SHA 3a85824View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba4b21 - Browse repository at this point
Copy the full SHA 4ba4b21View commit details
Commits on Mar 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4221d53 - Browse repository at this point
Copy the full SHA 4221d53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18d334c - Browse repository at this point
Copy the full SHA 18d334cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dabfd41 - Browse repository at this point
Copy the full SHA dabfd41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 126b714 - Browse repository at this point
Copy the full SHA 126b714View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc8a649 - Browse repository at this point
Copy the full SHA fc8a649View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04fb738 - Browse repository at this point
Copy the full SHA 04fb738View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.