This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
decrease build times for pack command #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetanley
force-pushed
the
decrease-pack-times
branch
2 times, most recently
from
8675638
to
018249b
Compare
- We can reuse the tarball and append new files (node binaries in this case) instead of compressing/extracting multiple times. This prevents un-necessary copying of files in the built tarball. We can also build all `targets` in parallel in the following way: - Download Node.js versions for targets in parallel instead of serially - Use [workerpool][1] to create gzip files in parallel - Run all `xz` compression with maximum available threads. xz has [supported multicore computation since 5.2 (2014)][1]. - Like gzip, run all `xz` compression in parallel instead of waiting for each target to build. Running this in the Heroku CLI produced identical tarballs in 65% amount of time (~111s seconds vs ~344 seconds before this change). It's likely even a bit faster since I was running it locally which has some boot-up time due to ts-node compiling typescript at runtime. [1]: https://www.npmjs.com/package/workerpool [2]: https://www.phoronix.com/scan.php?page=news_item&px=MTg3MDM
fivetanley
force-pushed
the
decrease-pack-times
branch
from
018249b
to
3eca56d
Compare
|
closing in favor of #330 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reuse the tarball and append new files (node binaries in this case) instead of compressing/extracting multiple times. This prevents un-necessary copying of files in the built tarball.
We can also build all
targetsin parallel in the following way:xzcompression with maximum available threads. xz has supported multicore computation since 5.2 (2014).xzcompression in parallel instead of waiting for each target to build.Running this in the Heroku CLI produced identical tarballs in 65% amount of time (~111s seconds vs ~344 seconds before this change). It's likely even a bit faster since I was running it locally which has some boot-up time due to ts-node compiling typescript at runtime.
This file brings in the
tardependency. This dependency is maintained by the npm team and is also cross-platform. This gets us quite a bit closer to allow building OClif CLIs on windows!