Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/fix table stack error #433

Merged
merged 7 commits into from Jun 23, 2022
Merged

Sm/fix table stack error #433

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69ccf09
test: watchable ut
mshanemc Jun 14, 2022
466384d
fix: giant tables don't exceed stack depth
mshanemc Jun 14, 2022
7d6cc43
test: timeouts for windows
mshanemc Jun 15, 2022
5423597
test: move scale tests to e2e because slow
mshanemc Jun 15, 2022
938a9ff
test: e2e clone w/ https
mshanemc Jun 15, 2022
31f27c6
fix: turn null/undefined into empty string
mshanemc Jun 23, 2022
a772511
Merge remote-tracking branch 'origin/main' into sm/fix-table-stack-error
mshanemc Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cli-ux/styled/table.ts
View file
Open in desktop
Expand Up @@ -19,7 +19,8 @@ class Table<T extends Record<string, unknown>> {
this.columns = Object.keys(columns).map((key: string) => {
const col = columns[key]
const extended = col.extended ?? false
const get = col.get ?? ((row: any) => row[key])
// turn null and undefined into empty strings by default
const get = col.get ?? ((row: any) => row[key] ?? '')
const header = typeof col.header === 'string' ? col.header : capitalize(key.replace(/_/g, ' '))
const minWidth = Math.max(col.minWidth ?? 0, sw(header) + 1)

Expand Down