Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing the default is wrong types #380

Merged
merged 3 commits into from Feb 28, 2022
Merged

fix: parsing the default is wrong types #380

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba08723
fix: parsing the default is wrong types
mshanemc Feb 25, 2022
1ea052a
Merge branch 'main' into sm/dont-parse-default
mshanemc Feb 25, 2022
4a8fc76
test: parsing and defaults with classes
mshanemc Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/parser/parse.ts
View file
Open in desktop
Expand Up @@ -208,12 +208,8 @@ export class Parser<T extends ParserInput, TFlags extends OutputFlags<T['flags']
if (!(k in flags) && flag.default !== undefined) {
this.metaData.flags[k] = {setFromDefault: true}
// eslint-disable-next-line no-await-in-loop
const defaultValue = (typeof flag.default === 'function' ? await flag.default({options: flag, flags, ...this.context}) : flag.default) as string
const parsedValue = flag.type === 'option' && flag.parse ?
// eslint-disable-next-line no-await-in-loop
await flag.parse(defaultValue, this.context) :
defaultValue
flags[k] = parsedValue
const defaultValue = (typeof flag.default === 'function' ? await flag.default({options: flag, flags, ...this.context}) : flag.default)
flags[k] = defaultValue
}
}

Expand Down