chore: code review

oclif · Oct 28, 2022 · 8b34afe · 8b34afe
1 parent e94f278
commit 8b34afe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/command.ts b/src/command.ts
@@ -263,7 +263,7 @@ export default abstract class Command {
 
       const deprecateAliases = this.ctor.flags[flag]?.deprecateAliases
       const aliases = this.ctor.flags[flag]?.aliases ?? []
-      if (deprecateAliases && aliases) {
+      if (deprecateAliases && aliases.length > 0) {
         const foundAliases = this.argv.filter(a => aliases.includes(a.replace(/-/g, '')))
         for (const alias of foundAliases) {
           this.warn(formatFlagDeprecationWarning(alias, {to: this.ctor.flags[flag]?.name}))

diff --git a/src/flags.ts b/src/flags.ts
@@ -37,7 +37,7 @@ export const help = (opts: Partial<BooleanFlag<boolean>> = {}) => {
     description: 'Show CLI help.',
     ...opts,
     parse: async (_: any, cmd: Command) => {
-      new Help(cmd.config).showHelp([cmd.id!, ...cmd.argv])
+      new Help(cmd.config).showHelp(cmd.id ? [cmd.id, ...cmd.argv] : cmd.argv)
       cmd.exit(0)
     },
   })