Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download when content disposition header missing #1680

Merged
merged 2 commits into from Jan 5, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Jan 5, 2023

Fixes #1679 .

Changes proposed in this PR:

  • add a default filename if content disposition header is missing

@codeclimate
Copy link

codeclimate bot commented Jan 5, 2023

Code Climate has analyzed commit 6046a03 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 79.9%.

View more on Code Climate.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bogdanfazakas bogdanfazakas merged commit b99bde9 into main Jan 5, 2023
@bogdanfazakas bogdanfazakas deleted the fix/smartcontract-file-download branch January 5, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when downloading an assets with smart contract storage type
3 participants